Hi Jarkko, kernel test robot noticed the following build warnings: [auto build test WARNING on johan-usb-serial/usb-next] [also build test WARNING on johan-usb-serial/usb-linus linus/master v6.3 next-20230421] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jarkko-Sonninen/USB-serial-xr-Add-TIOCGRS485-and-TIOCSRS485-ioctls/20230424-030038 base: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git usb-next patch link: https://lore.kernel.org/r/20230423185929.1595056-1-kasper%40iki.fi patch subject: [PATCH v4] USB: serial: xr: Add TIOCGRS485 and TIOCSRS485 ioctls config: ia64-randconfig-s053-20230423 (https://download.01.org/0day-ci/archive/20230424/202304241303.WkdqPPbt-lkp@xxxxxxxxx/config) compiler: ia64-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/a80fa27b4fe1974bad2427d7f3260012a04b721a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jarkko-Sonninen/USB-serial-xr-Add-TIOCGRS485-and-TIOCSRS485-ioctls/20230424-030038 git checkout a80fa27b4fe1974bad2427d7f3260012a04b721a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=ia64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/usb/serial/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202304241303.WkdqPPbt-lkp@xxxxxxxxx/ sparse warnings: (new ones prefixed by >>) >> drivers/usb/serial/xr_serial.c:856:26: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *to @@ got struct serial_rs485 *argp @@ drivers/usb/serial/xr_serial.c:856:26: sparse: expected void [noderef] __user *to drivers/usb/serial/xr_serial.c:856:26: sparse: got struct serial_rs485 *argp >> drivers/usb/serial/xr_serial.c:872:36: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got struct serial_rs485 *argp @@ drivers/usb/serial/xr_serial.c:872:36: sparse: expected void const [noderef] __user *from drivers/usb/serial/xr_serial.c:872:36: sparse: got struct serial_rs485 *argp drivers/usb/serial/xr_serial.c:881:26: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *to @@ got struct serial_rs485 *argp @@ drivers/usb/serial/xr_serial.c:881:26: sparse: expected void [noderef] __user *to drivers/usb/serial/xr_serial.c:881:26: sparse: got struct serial_rs485 *argp >> drivers/usb/serial/xr_serial.c:893:49: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct serial_rs485 *argp @@ got void [noderef] __user *argp @@ drivers/usb/serial/xr_serial.c:893:49: sparse: expected struct serial_rs485 *argp drivers/usb/serial/xr_serial.c:893:49: sparse: got void [noderef] __user *argp drivers/usb/serial/xr_serial.c:895:49: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct serial_rs485 *argp @@ got void [noderef] __user *argp @@ drivers/usb/serial/xr_serial.c:895:49: sparse: expected struct serial_rs485 *argp drivers/usb/serial/xr_serial.c:895:49: sparse: got void [noderef] __user *argp vim +856 drivers/usb/serial/xr_serial.c 848 849 static int xr_get_rs485_config(struct tty_struct *tty, 850 struct serial_rs485 *argp) 851 { 852 struct usb_serial_port *port = tty->driver_data; 853 struct xr_data *data = usb_get_serial_port_data(port); 854 855 mutex_lock(&data->lock); > 856 if (copy_to_user(argp, &data->rs485, sizeof(data->rs485))) { 857 mutex_unlock(&data->lock); 858 return -EFAULT; 859 } 860 mutex_unlock(&data->lock); 861 862 return 0; 863 } 864 865 static int xr_set_rs485_config(struct tty_struct *tty, 866 struct serial_rs485 *argp) 867 { 868 struct usb_serial_port *port = tty->driver_data; 869 struct xr_data *data = usb_get_serial_port_data(port); 870 struct serial_rs485 rs485; 871 > 872 if (copy_from_user(&rs485, argp, sizeof(rs485))) 873 return -EFAULT; 874 xr_sanitize_serial_rs485(&rs485); 875 876 mutex_lock(&data->lock); 877 data->rs485 = rs485; 878 xr_set_flow_mode(tty, port, NULL); 879 mutex_unlock(&data->lock); 880 881 if (copy_to_user(argp, &rs485, sizeof(rs485))) 882 return -EFAULT; 883 884 return 0; 885 } 886 887 static int xr_ioctl(struct tty_struct *tty, unsigned int cmd, unsigned long arg) 888 { 889 void __user *argp = (void __user *)arg; 890 891 switch (cmd) { 892 case TIOCGRS485: > 893 return xr_get_rs485_config(tty, argp); 894 case TIOCSRS485: 895 return xr_set_rs485_config(tty, argp); 896 } 897 898 return -ENOIOCTLCMD; 899 } 900 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
