On 4/18/23 6:56 PM, Greg Kroah-Hartman wrote:
On Tue, Apr 18, 2023 at 03:01:39PM +0200, Johan Hovold wrote:
On Tue, Apr 18, 2023 at 05:48:35PM +0530, Udipto Goswami wrote:
First, the subject of this patch looks wrong.
When the dwc3 device is runtime suspended, various required clocks would
get disabled and it is not guaranteed that access to any registers would
work. Depending on the SoC glue, a register read could be as benign as
returning 0 or be fatal enough to hang the system.
In order to prevent such scenarios of fatal errors, make sure to resume
dwc3 then allow the function to proceed.
Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
I did not sign-off on this patch (and neither did Oliver I presume).
You must never add a SoB on behalf on someone else without their
permission. Please read Documentation/process/submitting-patches.rst and
make sure you understand what SoB means before sending any further
patches.
Ah, I thought so :(
Udipto, please go complete the developer legal training that I know your
company provides for dealing with things like this as they take it very
seriously, before you resubmit this, or any other kernel patches.
thanks,
greg k-h
Hi Greg, Johan, Oliver,
Apologies for this, will go through the guidelines and rework the patch
accordingly.
