On Tue, Apr 18, 2023 at 07:38:16PM +0530, Basavaraj Natikar wrote: > Currently, the pci_resume method has only a flag indicating whether the > system is resuming from hibernation. In order to handle all PM events like > AUTO_RESUME, SUSPEND etc change the pci_resume method to handle all PM > events. > > Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx> > --- > drivers/usb/core/hcd-pci.c | 14 ++++++++------ > drivers/usb/host/ehci-pci.c | 3 ++- > drivers/usb/host/ohci-pci.c | 8 +++++++- > drivers/usb/host/uhci-pci.c | 10 +++++++--- > drivers/usb/host/xhci-pci.c | 4 ++-- > drivers/usb/host/xhci.c | 3 ++- > drivers/usb/host/xhci.h | 2 +- > include/linux/usb/hcd.h | 2 +- > 8 files changed, 30 insertions(+), 16 deletions(-) > > diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c > index ab2f3737764e..bef092da477a 100644 > --- a/drivers/usb/core/hcd-pci.c > +++ b/drivers/usb/core/hcd-pci.c > @@ -415,12 +415,15 @@ static int check_root_hub_suspended(struct device *dev) > return 0; > } > > -static int suspend_common(struct device *dev, bool do_wakeup) > +static int suspend_common(struct device *dev, int event) Shouldn't there be a PM_EVENT_* type for this so that we can properly type-check that it is being used properly everywhere? Much like we can do for GFP_* flags? Not the fault of this patch, just a general comment... thanks, greg k-h
