Hello! On 4/18/23 12:07 PM, Li Yang wrote: > Smatch reports: > drivers/usb/phy/phy-tahvo.c: tahvo_usb_probe() > warn: missing unwind goto? > > After geting irq, if ret < 0, it will return without error handling to > free memory. > Just add error handling to fix this problem. Oops, I'm sorry for missing that one... > Fixes: 0d45a1373e66 ("usb: phy: tahvo: add IRQ check") > Signed-off-by: Li Yang <lidaxian@xxxxxxxxxxx> > Reviewed-by: Dongliang Mu <dzm91@xxxxxxxxxxx> > --- > The issue is found by static analysis, and the patch remains untest. > --- > drivers/usb/phy/phy-tahvo.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c > index f2d2cc586c5b..184a5f3d7473 100644 > --- a/drivers/usb/phy/phy-tahvo.c > +++ b/drivers/usb/phy/phy-tahvo.c > @@ -390,8 +390,11 @@ static int tahvo_usb_probe(struct platform_device *pdev) > dev_set_drvdata(&pdev->dev, tu); > > tu->irq = ret = platform_get_irq(pdev, 0); > - if (ret < 0) > - return ret; > + if (ret < 0) { > + dev_err(&pdev->dev, "could not get irq: %d\n", > + ret); Adding the error message needs another patch, strictly speaking... > + goto err_remove_phy; > + } > ret = request_threaded_irq(tu->irq, NULL, tahvo_usb_vbus_interrupt, > IRQF_ONESHOT, > "tahvo-vbus", tu); MBR, Sergey