On 17/04/2023 13:47, Dmitry Rokosov wrote:
Hello Martin,
Thank you for quick review, appreciate it!
Please find my comments below and in the other replies.
On Sun, Apr 16, 2023 at 10:56:36PM +0200, Martin Blumenstingl wrote:
On Fri, Apr 14, 2023 at 5:24 PM Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> wrote:
[...]
static const struct dwc3_meson_g12a_drvdata a1_drvdata = {
- .otg_switch_supported = false,
+ .otg_switch_supported = true,
it would be great if you could also follow up with a patch that
removes otg_switch_supported.
A1 was the only variant that needed it and after this patch it's just dead code.
It makes sense. I thought about it before sending the first version, but
I found a counter-argument: future SoCs may use this parameter.
But if you ask, I will remove 'otg_switch_supported' in the next version
Please remove it, it's easy to add it again if needed.
Neil
