On 13/04/2023 19:31, Sebastian Reichel wrote: > Add compatible for RK3588 OHCI. As far as I know it's fully > compatible with generic-ohci. > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> Sebastian, Can you fix PATCH subject part in all your submissions? There should be a space between PATCH and v. Just like `git format-patch` creates. If you use other tools for this, fix them so they don't create other format. You also need to rebase your patches - this is something old and cannot be applied. > --- > .../devicetree/bindings/usb/generic-ohci.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > index a9ba7257b884..4feb993af53b 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > @@ -44,6 +44,7 @@ properties: > - hpe,gxp-ohci > - ibm,476gtr-ohci > - ingenic,jz4740-ohci > + - rockchip,rk3588-ohci > - snps,hsdk-v1.0-ohci > - const: generic-ohci > - enum: > @@ -69,7 +70,7 @@ properties: > > clocks: > minItems: 1 > - maxItems: 3 > + maxItems: 4 > description: | > In case the Renesas R-Car Gen3 SoCs: > - if a host only channel: first clock should be host. > @@ -147,6 +148,19 @@ allOf: > then: > properties: > transceiver: false > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3588-ohci > + then: > + properties: > + clocks: > + minItems: 4 > + else: > + properties: > + clocks: Please test the patches before sending. If you tested, you would see warnings here. You need minItems: 1. > + maxItems: 3 > > additionalProperties: false > Best regards, Krzysztof
