On Wed, Apr 5, 2023 at 8:06 PM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Apr 05, 2023 at 08:03:16PM +0200, Bastien Nocera wrote: > > On Wed, 2023-04-05 at 19:13 +0200, Greg Kroah-Hartman wrote: > > > On Wed, Apr 05, 2023 at 11:27:54AM +0200, Bastien Nocera wrote: > > > > Fix wrongly named 'dev' parameter in doc block, should have been > > > > iface: > > > > drivers/usb/core/message.c:1939: warning: Function parameter or > > > > member 'iface' not described in 'usb_set_wireless_status' > > > > drivers/usb/core/message.c:1939: warning: Excess function parameter > > > > 'dev' description in 'usb_set_wireless_status' > > > > > > > > And fix missing struct member doc in kernel API, and reorder to > > > > match struct: > > > > include/linux/usb.h:270: warning: Function parameter or member > > > > 'wireless_status_work' not described in 'usb_interface' > > > > > > > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > > > > Link: > > > > https://lore.kernel.org/linux-next/20230405114807.5a57bf46@xxxxxxxxxxxxxxxx/T/#t > > > > Fixes: 0a4db185f078 ("USB: core: Add API to change the > > > > wireless_status") > > > > > > I do not see that git commit id anywhere, where is it from? What > > > tree? > > > > > > Ah, input tree, not much I can do there... > > > > Yes, it's from the hid tree. > > > > Benjamin is waiting on either Alan or yourself ack'ing the changes > > before pushing it through the hid tree, to avoid stepping on somebody > > else's toes. > > > > The patch seems to fix the warnings in my local tests, let me know if > > you have any comments about the wording. > > Nope: > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Thanks! I have fixed a small checkpatch warning about using space before tab and applied as the b4 thank you notice should have already mentioned. Cheers, Benjamin
