Hi, > -----Original Message----- > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: Wednesday, April 5, 2023 4:22 PM > To: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) > <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > Cc: mathias.nyman@xxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] usb: host: xhci-plat: Use dev_is_pci() helper > > On Wed, Apr 05, 2023 at 04:01:41PM +0900, Nobuhiro Iwamatsu wrote: > > Use common dev_is_pci() helper for checking PCI devices. > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > --- > > drivers/usb/host/xhci-plat.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/host/xhci-plat.c > > b/drivers/usb/host/xhci-plat.c index b9f9625467d61e..2c95189424fa6e > > 100644 > > --- a/drivers/usb/host/xhci-plat.c > > +++ b/drivers/usb/host/xhci-plat.c > > @@ -363,7 +363,7 @@ static int xhci_generic_plat_probe(struct > platform_device *pdev) > > is_acpi_device_node(sysdev->fwnode)) > > break; > > #ifdef CONFIG_PCI > > - else if (sysdev->bus == &pci_bus_type) > > + else if (dev_is_pci(sysdev)) > > With that change, you can also get rid of the #ifdef lines too, right? Yes, that's right. I will send v2 patch with it. Best regards, Nobuhiro
