On 05/04/2023 16:15, Krishna Kurapati PSSNV wrote: > > > On 4/5/2023 7:31 PM, Krzysztof Kozlowski wrote: >> On 05/04/2023 14:57, Krishna Kurapati wrote: >>> Add bindings to indicate properties required to support multiport >>> on Snps Dwc3 controller. >>> >>> Suggested-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> >>> Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx> >>> --- >>> Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@xxxxxxxxxxx/ >> >> You did not test it at v4 and you got report for this. Your changelog in >> commit msg does not mention fixing it. >> >> It looks like you did not test it for the second time (or sixth time). >> >> Best regards, >> Krzysztof >> > Hi Krzysztof, > > I did do a dt_binding_check and I got the following result: > > kriskura@hu-kriskura-hyd:/local/mnt/workspace/krishna/skales2/skales/kernel$ > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/snps,dwc3.yaml > HOSTCC scripts/basic/fixdep > HOSTCC scripts/dtc/dtc.o > HOSTCC scripts/dtc/flattree.o > HOSTCC scripts/dtc/fstree.o > HOSTCC scripts/dtc/data.o > HOSTCC scripts/dtc/livetree.o > HOSTCC scripts/dtc/treesource.o > HOSTCC scripts/dtc/srcpos.o > HOSTCC scripts/dtc/checks.o > HOSTCC scripts/dtc/util.o > LEX scripts/dtc/dtc-lexer.lex.c > YACC scripts/dtc/dtc-parser.tab.[ch] > HOSTCC scripts/dtc/dtc-lexer.lex.o > HOSTCC scripts/dtc/dtc-parser.tab.o > HOSTLD scripts/dtc/dtc > LINT Documentation/devicetree/bindings > invalid config: unknown option "max-spaces-inside-empty" for rule "brackets" > xargs: /usr/bin/yamllint: exited with status 255; aborting > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: > ignoring, error in schema: properties: qcom,pre-emphasis-duration-bp > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: > ignoring, error in schema: properties: gpio-controller > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: > ignoring, error in schema: patternProperties: ^thermistor@: properties: > adi,excitation-current-nanoamp > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: > ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: > properties: adi,excitation-current-0-nanoamp All these are some errors, maybe coming from your schema, maybe from next. You can narrow the tests with DT_SCHEMA_FILES (as mentioned in guide). Best regards, Krzysztof
