Le mercredi 05 avril 2023 à 16:10 +0200, Uwe Kleine-König a écrit :
> The .remove() callback for a platform driver returns an int which
> makes
> many driver authors wrongly assume it's possible to do error handling
> by
> returning an error code. However the value returned is (mostly)
> ignored
> and this typically results in resource leaks. To improve here there
> is a
> quest to make the remove callback return void. In the first step of
> this
> quest all drivers are converted to .remove_new() which already
> returns
> void.
>
> Trivially convert this driver from always returning zero in the
> remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
Cheers,
-Paul
> ---
> drivers/usb/musb/jz4740.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
> index c7b1d2a394d9..5aabdd7e2511 100644
> --- a/drivers/usb/musb/jz4740.c
> +++ b/drivers/usb/musb/jz4740.c
> @@ -308,14 +308,12 @@ static int jz4740_probe(struct platform_device
> *pdev)
> return ret;
> }
>
> -static int jz4740_remove(struct platform_device *pdev)
> +static void jz4740_remove(struct platform_device *pdev)
> {
> struct jz4740_glue *glue = platform_get_drvdata(pdev);
>
> platform_device_unregister(glue->pdev);
> clk_disable_unprepare(glue->clk);
> -
> - return 0;
> }
>
> static const struct of_device_id jz4740_musb_of_match[] = {
> @@ -327,7 +325,7 @@ MODULE_DEVICE_TABLE(of, jz4740_musb_of_match);
>
> static struct platform_driver jz4740_driver = {
> .probe = jz4740_probe,
> - .remove = jz4740_remove,
> + .remove_new = jz4740_remove,
> .driver = {
> .name = "musb-jz4740",
> .of_match_table = jz4740_musb_of_match,
