Hi Greg, Thanks for the review. On Sat, Mar 25, 2023 at 05:20:09PM +0100, Greg Kroah-Hartman wrote: > On Sat, Mar 25, 2023 at 11:47:06PM +0800, Ye Xiang wrote: > > This patch implements the USB part of Intel USB-I2C/GPIO/SPI adapter > > device named "La Jolla Cove Adapter" (LJCA). > > > > The communication between the various LJCA module drivers and the > > hardware will be muxed/demuxed by this driver. Three modules ( > > I2C, GPIO, and SPI) are supported currently. > > > > Each sub-module of LJCA device is identified by type field within > > the LJCA message header. > > > > The minimum code in ASL that covers this board is > > As this requires ACPI, why are you not saying so in your Kconfig entry? I would add a `depends on ACPI` item on the Kconfig entry so that the CONFI_ACPI macro can be removed from usb-ljca, because our use case with LJCA currently needs the ACPI binding. > What good would this driver be without ACPI enabled? Before, I just tried to make it compatible with other platforms that don't support ACPI but want to use LJCA device. But, We don't have this use case until now. Thanks Ye Xiang
