On Fri, Mar 24, 2023 at 02:09:34PM +0800, Mingxuan Xiang wrote: > According to the description of platform_get_irq() > * Return: non-zero IRQ number on success, > negative error number on failure. > and the code, platform_get_irq() will return -EINVAL > instead of IRQ0. > > So platform_get_irq() no longer returns 0, there is no > need to check whether the return value is 0. > > Found by Smatch: > drivers/usb/dwc3/host.c:60 dwc3_host_get_irq() > warn: platform_get_irq() does not return zero > > Signed-off-by: Mingxuan Xiang <mx_xiang@xxxxxxxxxxx> > --- > v2->v3: remove curly braces > v1->v2: remove redundant goto > Only compile tested. Reviewed-by: Dan Carpenter <error27@xxxxxxxxx> regards, dan carpenter
