On Thu, Mar 23, 2023 at 02:00:35PM +0300, Dan Carpenter wrote: > irq = platform_get_irq(dwc3_pdev, 0); > if (irq > 0) { > dwc3_host_fill_xhci_irq_res(dwc, irq, NULL); > - goto out; > + return irq; > } > > - if (!irq) > - irq = -EINVAL; > - > -out: > - return irq; > + return -ENODEV; Oh wait. We actually need to propagate the error code here because of -EPROBE_DEFER so my patch introduces a bug. regards, dan carpenter