On Wed, Mar 22, 2023 at 10:52:44PM +0100, Krzysztof Kozlowski wrote: > On 22/03/2023 11:44, Varadarajan Narayanan wrote: > > Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> > > > > --- > > Changes in v2: > > - Updated sections missed in previous patch > > --- > > .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > index e81a382..beae44c 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > @@ -21,6 +21,7 @@ properties: > > enum: > > - qcom,ipq6018-qmp-usb3-phy > > - qcom,ipq8074-qmp-usb3-phy > > + - qcom,ipq9574-qmp-usb3-phy > > - qcom,msm8996-qmp-usb3-phy > > - qcom,msm8998-qmp-usb3-phy > > - qcom,qcm2290-qmp-usb3-phy > > @@ -204,6 +205,27 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,ipq9574-qmp-usb3-phy > > + then: > > + properties: > > + clocks: > > + maxItems: 2 > > toplevel defines minItems as 3, so are you sure this works? Did you test it? Yes, this is tested. Able to do I/O. We only have 2 items. Is it ok change the minItems to 2? Thanks Varada > > Best regards, > Krzysztof >