Re: [PATCH] usb: host: u132-hcd: Delete driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 21, 2023 at 11:36:38AM +0100, Uwe Kleine-König wrote:
> This driver got its last actual change in 2006 and is probably unused as
> nowbody should use a cardbus to USB adapter any more.
> 
> If it were still used, the driver was in urgent need for maintainer
> love. (Explicit kref handling, underdocumented locking, .remove() can
> return errors ...)
> 
> Also the link in the (now removed) help text doesn't look actively
> maintained. According to archive.org it forwarded to
> http://www.copenhagen-hotel.net/ already back in 2018.
> 
> So don't waste more time on this driver and just delete it.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
>  arch/mips/configs/mtx1_defconfig      |    1 -
>  arch/powerpc/configs/ppc6xx_defconfig |    1 -
>  drivers/usb/Makefile                  |    1 -
>  drivers/usb/host/Kconfig              |   27 -
>  drivers/usb/host/Makefile             |    1 -
>  drivers/usb/host/u132-hcd.c           | 3239 -------------------------
>  drivers/usb/misc/Kconfig              |    2 -
>  7 files changed, 3272 deletions(-)
>  delete mode 100644 drivers/usb/host/u132-hcd.c
> 
> diff --git a/arch/mips/configs/mtx1_defconfig b/arch/mips/configs/mtx1_defconfig
> index 89a1511d2ee4..7b6a2a9daa10 100644
> --- a/arch/mips/configs/mtx1_defconfig
> +++ b/arch/mips/configs/mtx1_defconfig
> @@ -497,7 +497,6 @@ CONFIG_USB_EHCI_ROOT_HUB_TT=y
>  CONFIG_USB_OHCI_HCD=m
>  CONFIG_USB_OHCI_HCD_PLATFORM=m
>  CONFIG_USB_UHCI_HCD=m
> -CONFIG_USB_U132_HCD=m
>  CONFIG_USB_SL811_HCD=m
>  CONFIG_USB_SL811_CS=m
>  CONFIG_USB_ACM=m
> diff --git a/arch/powerpc/configs/ppc6xx_defconfig b/arch/powerpc/configs/ppc6xx_defconfig
> index 110258277959..fd5cc93c4a99 100644
> --- a/arch/powerpc/configs/ppc6xx_defconfig
> +++ b/arch/powerpc/configs/ppc6xx_defconfig
> @@ -845,7 +845,6 @@ CONFIG_USB_OHCI_HCD=m
>  CONFIG_USB_OHCI_HCD_PPC_OF_BE=y
>  CONFIG_USB_OHCI_HCD_PPC_OF_LE=y
>  CONFIG_USB_UHCI_HCD=m
> -CONFIG_USB_U132_HCD=m
>  CONFIG_USB_SL811_HCD=m
>  CONFIG_USB_ACM=m
>  CONFIG_USB_PRINTER=m
> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
> index a81e6ef293af..3a9a0dd4be70 100644
> --- a/drivers/usb/Makefile
> +++ b/drivers/usb/Makefile
> @@ -31,7 +31,6 @@ obj-$(CONFIG_USB_FHCI_HCD)	+= host/
>  obj-$(CONFIG_USB_XHCI_HCD)	+= host/
>  obj-$(CONFIG_USB_SL811_HCD)	+= host/
>  obj-$(CONFIG_USB_ISP1362_HCD)	+= host/
> -obj-$(CONFIG_USB_U132_HCD)	+= host/
>  obj-$(CONFIG_USB_R8A66597_HCD)	+= host/
>  obj-$(CONFIG_USB_FSL_USB2)	+= host/
>  obj-$(CONFIG_USB_FOTG210_HCD)	+= host/
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index eacb603ad1b2..c170672f847e 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -622,33 +622,6 @@ config FHCI_DEBUG
>  	  Say "y" to see some FHCI debug information and statistics
>  	  through debugfs.
>  
> -config USB_U132_HCD
> -	tristate "Elan U132 Adapter Host Controller"
> -	depends on USB_FTDI_ELAN

I think you can also delete this driver (drivers/usb/misc/ftdi-elan.c)
as well as it is the same expired domain and came in at the same time.

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux