Hello, this driver is horrifying. I made these two cleanups but there is more to do: - Drop the explicit kref handling (or at least only do it in one place) - Simplify .remove() further (I think at entry ->going should never be > 1 (or even > 0?) Also "u132->going++ > 1" means the device is already gone, not "being removed". - Fix .remove() not to return -ENODEV; - I'm sure there is more. Uwe Kleine-König (2): usb: host: u132-hcd: Various style improvements usb: host: u132-hcd: Drop if with an always true condition drivers/usb/host/u132-hcd.c | 452 +++++++++++++++++++----------------- 1 file changed, 236 insertions(+), 216 deletions(-) base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6 -- 2.39.2
