On 18/03/2023 13:18, Bryan O'Donoghue wrote: > Add a YAML binding for the power-delivery PHY silicon interface inside > Qualcomm's pm8150b hardware block. Subject: drop second/last, redundant "YAML schema". The "dt-bindings" prefix is already stating that. This applies to other patches as well. > > The pdphy driver operates with a type-c driver inside of a high level > single TCPM device to provide overall TCPM functionality. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > --- > .../bindings/usb/qcom,pmic-pdphy.yaml | 89 +++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmic-pdphy.yaml > > diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-pdphy.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-pdphy.yaml > new file mode 100644 > index 0000000000000..79318e3da41e6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-pdphy.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/usb/qcom,pmic-pdphy.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; All comments from previous patch apply > + > +title: Qualcomm PMIC based USB PDPHY driver > + > +maintainers: > + - Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > + > +description: | > + Qualcomm PMIC Power Delivery PHY driver > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/usb/typec/qcom,pmic-pdphy.h> > + > + pm8150b { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pm8150b_pdphy: pdphy@1700 { I guess: phy@ (and drop the label) Best regards, Krzysztof
