RE: [EXT] Re: [PATCH RESEND v2 2/2] usb: chipidea: core: fix possible concurrent when switch role

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Friday, March 17, 2023 2:02 PM
> To: Xu Yang <xu.yang_2@xxxxxxx>
> Cc: peter.chen@xxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Jun Li <jun.li@xxxxxxx>
> Subject: [EXT] Re: [PATCH RESEND v2 2/2] usb: chipidea: core: fix possible concurrent when switch role
> 
> Caution: EXT Email
> 
> On Fri, Mar 17, 2023 at 01:52:03PM +0800, Xu Yang wrote:
> > The user may call role_store() when driver is handling
> > ci_handle_id_switch() which is triggerred by otg event or power lost
> > event. Unfortunately, the controller may go into chaos in this case.
> > Fix this by protecting it with mutex lock.
> >
> > Fixes: a932a8041ff9 ("usb: chipidea: core: add sysfs group")
> > cc: <stable@xxxxxxxxxxxxxxx>
> > Acked-by: Peter Chen <peter.chen@xxxxxxxxxx>
> > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx>
> >
> > ---
> > changes since v1:
> > - modify description for mutex member
> > - wrap role variable in ci_handle_id_switch() too
> 
> There are 2 "v2 2/2" patches here, which one is correct?

Sorry, it's my mistake.

> 
> Can you send a v3 with just the needed patches?

V3 has been sent.

Thanks,
Xu Yang

> 
> thanks,
> 
> greg k-h




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux