> -----Original Message----- > From: gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: Friday, March 17, 2023 12:51 PM > To: Xu Yang <xu.yang_2@xxxxxxx> > Cc: Peter Chen <peter.chen@xxxxxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Jun Li > <jun.li@xxxxxxx> > Subject: Re: [EXT] Re: [PATCH v2 1/3] usb: chipdea: core: don't return -EINVAL if request role is the same with current role > > Caution: EXT Email > > On Fri, Mar 17, 2023 at 02:37:47AM +0000, Xu Yang wrote: > > Hi Greg, > > > > > -----Original Message----- > > > From: gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx> > > > Sent: Thursday, March 16, 2023 7:55 PM > > > To: Xu Yang <xu.yang_2@xxxxxxx> > > > Cc: Peter Chen <peter.chen@xxxxxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Jun Li > > > <jun.li@xxxxxxx> > > > Subject: Re: [EXT] Re: [PATCH v2 1/3] usb: chipdea: core: don't return -EINVAL if request role is the same with current > role > > > > > > Caution: EXT Email > > > > > > On Thu, Mar 16, 2023 at 09:57:05AM +0000, Xu Yang wrote: > > > > Hi Greg, > > > > > > > > > -----Original Message----- > > > > > From: Peter Chen <peter.chen@xxxxxxxxxx> > > > > > Sent: Friday, February 10, 2023 4:55 PM > > > > > To: Xu Yang <xu.yang_2@xxxxxxx> > > > > > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Jun Li > > > <jun.li@xxxxxxx> > > > > > Subject: [EXT] Re: [PATCH v2 1/3] usb: chipdea: core: don't return -EINVAL if request role is the same with current > role > > > > > > > > > > Caution: EXT Email > > > > > > > > > > On 22-11-30 16:12:29, Xu Yang wrote: > > > > > > It should not return -EINVAL if the request role is the same with current > > > > > > role, return non-error and without do anything instead. > > > > > > > > > > > > Fixes: a932a8041ff9 ("usb: chipidea: core: add sysfs group") > > > > > > cc: <stable@xxxxxxxxxxxxxxx> > > > > > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx> > > > > > > > > > > Acked-by: Peter Chen <peter.chen@xxxxxxxxxx> > > > > > > > > Could you please add these three patches to your repo? > > > > > > Can you please resend them, I don't seem to have them anymore. Also > > > split this into 2 different series, one for bugfixes-only, that needs to > > > go to Linus for 6.3-final, and the others that are new features, to go > > > for 6.4-rc1. > > > > Patch 2/3 is a bugfix, but it depends on patch 1/3. I cannot simply > > separate them. After I resend them, could you please let them all go > > to Linus for 6.4-rc1? > > Resend and I will review, but that sounds like you also need to mark > patch 1 as a fix, and then patch 3 is not part of the series and can be > separate, right? Yes, understood. Thanks > > What would you do if you were in my position here? Make it easy for > maintainers please :) > > thanks, > > greg k-h