Re: [PATCH 3/3 v2] xhci: Add tests for TRB address translation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 05, 2009 at 02:36:06PM -0800, Sarah Sharp wrote:
> It's not surprising that the transfer request buffer (TRB) physical to
> virtual address translation function has bugs in it, since I wrote most of
> it at 4am last October.  Add a test suite to check the TRB math.  This
> runs at memory initialization time, and causes the driver to fail to load
> if the TRB math fails.
> 
> Please excuse the excessively long lines in the test vectors; they can't
> really be made shorter and still be readable.
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> ---
> 
> This should fix your build failure.

It does, but it still has the following build warning:
	drivers/usb/host/xhci-mem.c: In function ‘xhci_test_trb_in_td’:
	drivers/usb/host/xhci-mem.c:881: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 5 has type ‘dma_addr_t’

when building on i386.

Care to fix this up and resend it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux