On Thu, Mar 9, 2023 at 10:53 AM Yongqin Liu <yongqin.liu@xxxxxxxxxx> wrote: > > Hi, Saravana > > Sorry for the lateness, I was just aware of this today. No worries. > I tested with the ACK android-mainline branch + the 12 commits ending > with fb42378dcc7f > + the 4 commits of this series + hikey960 AOSP Master userspace. > The hikey960 Android build could boot to the home screen, no stuck there, Thanks for testing! Can you confirm what happens if you drop the "12 commits ending with fb42378dcc7f" ? Does it get stuck at boot or have some limited functionality? It's surprising that for the same type of DT node, in your case fw_devlink is able to handle it correctly, but no so for Martin's case. -Saravana > > Here is the link of the logat in case you want to check some message here: > https://gist.github.com/liuyq/6525af08c547cd2e494af5d1c8b181b5 > > Thanks, > Yongqin Liu > On Fri, 10 Mar 2023 at 02:05, Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > > > Greg, > > > > Don't pull in this series please. It needs more testing from the folks > > I cc'ed and it's already breaking things for Martin. This needs more > > revisions. > > > > -Saravana > > > > On Wed, Mar 1, 2023 at 1:49 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > > > > > Yongqin, Martin, Amelie, > > > > > > We recent refactor of fw_devlink that ends with commit fb42378dcc7f > > > ("mtd: mtdpart: Don't create platform device that'll never probe"), > > > fw_devlink is smarter and doesn't depend on compatible property. So, I > > > don't think these calls are needed anymore. But I don't have these > > > devices to test on and be sure and the hardware I use to test changes > > > doesn't have this issue either. > > > > > > Can you please test these changes on the hardware where you hit the > > > issue to make sure things work as expected? > > > > > > Yongqin, If you didn't have the context, this affected hikey960. > > > > > > Greg, > > > > > > Let's wait for some tests before we land these. > > > > > > Thanks, > > > Saravana > > > > > > Cc: Yongqin Liu <yongqin.liu@xxxxxxxxxx> > > > Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > > > Cc: Martin Kepplinger <martin.kepplinger@xxxxxxx> > > > Cc: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx> > > > > > > Saravana Kannan (4): > > > usb: typec: stusb160x: Remove use of > > > fw_devlink_purge_absent_suppliers() > > > usb: typec: tipd: Remove use of fw_devlink_purge_absent_suppliers() > > > usb: typec: tcpm: Remove use of fw_devlink_purge_absent_suppliers() > > > driver core: Delete fw_devlink_purge_absent_suppliers() > > > > > > drivers/base/core.c | 16 ---------------- > > > drivers/usb/typec/stusb160x.c | 9 --------- > > > drivers/usb/typec/tcpm/tcpm.c | 9 --------- > > > drivers/usb/typec/tipd/core.c | 9 --------- > > > include/linux/fwnode.h | 1 - > > > 5 files changed, 44 deletions(-) > > > > > > -- > > > 2.39.2.722.g9855ee24e9-goog > > > > > > > -- > Best Regards, > Yongqin Liu > --------------------------------------------------------------- > #mailing list > linaro-android@xxxxxxxxxxxxxxxx > http://lists.linaro.org/mailman/listinfo/linaro-android
