On Tue, Mar 07, 2023 at 11:17:05AM +0200, Heikki Krogerus wrote: > Hi Hans, > > On Mon, Mar 06, 2023 at 11:33:57AM +0100, Hans de Goede wrote: > > When ucsi_init() fails, ucsi->connector is NULL, yet in case of > > ucsi_acpi we may still get events which cause the ucs_acpi code to call > > ucsi_connector_change(), which then derefs the NULL ucsi->connector > > pointer. > > > > Fix this by not setting ucsi->ntfy inside ucsi_init() until ucsi_init() > > has succeeded, so that ucsi_connector_change() ignores the events > > because UCSI_ENABLE_NTFY_CONNECTOR_CHANGE is not set in the ntfy mask. > > > > Fixes: bdc62f2bae8f ("usb: typec: ucsi: Simplified registration and I/O API") > > Cc: stable@xxxxxxxxxxxxxxx > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > There is now a bug report for this in the kernel.org bugzilla. Can you > add a Link tag pointing to it so the it gets updated automagically: > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217106 My tools should pick this up, thanks. greg k-h