Am Mittwoch, dem 01.03.2023 um 13:49 -0800 schrieb Saravana Kannan: > Yongqin, Martin, Amelie, > > We recent refactor of fw_devlink that ends with commit fb42378dcc7f > ("mtd: mtdpart: Don't create platform device that'll never probe"), > fw_devlink is smarter and doesn't depend on compatible property. So, > I > don't think these calls are needed anymore. But I don't have these > devices to test on and be sure and the hardware I use to test changes > doesn't have this issue either. > > Can you please test these changes on the hardware where you hit the > issue to make sure things work as expected? > > Yongqin, If you didn't have the context, this affected hikey960. > > Greg, > > Let's wait for some tests before we land these. > > Thanks, > Saravana hi Sravana, I picked the 12 commits leading up to commit fb42378dcc7f ("mtd: mtdpart: Don't create platform device that'll never probe") ( https://source.puri.sm/martin.kepplinger/linux-next/-/commits/test_fw_devlink ) and included the tipd patch below to test it. With that, I get the following errors: [ 0.237931] imx-uart 30890000.serial: Failed to create device link with regulator-gnss [ 0.334054] nwl-dsi 30a00000.mipi-dsi: Failed to create device link with regulator-lcd-1v8 [ 0.346964] nwl-dsi 30a00000.mipi-dsi: Failed to create device link with backlight-dsi but they are independent of this final tipd patch below. I'll test a real linux-next tree soon, for completeness, maybe I missed something? Anyways, on that tree, your tipd removal patch breaks type-c still for me, imx8mq-librem5.dtsi just to give a first reply quickly... thanks, martin > > Cc: Yongqin Liu <yongqin.liu@xxxxxxxxxx> > Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > Cc: Martin Kepplinger <martin.kepplinger@xxxxxxx> > Cc: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx> > > Saravana Kannan (4): > usb: typec: stusb160x: Remove use of > fw_devlink_purge_absent_suppliers() > usb: typec: tipd: Remove use of fw_devlink_purge_absent_suppliers() > usb: typec: tcpm: Remove use of fw_devlink_purge_absent_suppliers() > driver core: Delete fw_devlink_purge_absent_suppliers() > > drivers/base/core.c | 16 ---------------- > drivers/usb/typec/stusb160x.c | 9 --------- > drivers/usb/typec/tcpm/tcpm.c | 9 --------- > drivers/usb/typec/tipd/core.c | 9 --------- > include/linux/fwnode.h | 1 - > 5 files changed, 44 deletions(-) >