On Thu, Feb 16, 2023 at 9:07 AM Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote: > > - dev_err(dev, "init %s fail, %d\n", dev_name(dev), retval); > > - return retval; > > + return dev_err_probe(dev, retval, "init %s fail\n", dev_name(dev)); > > Hi, > the patch is already applied, but is dev_name(dev) needed here? Not really but it's not a big deal either, it's just a string. Feel free to send an incremental patch dropping it :) Yours, Linus Walleij