On Mon, Feb 13, 2023 at 06:00:30PM +0000, Gopal, Saranya wrote: > > So you deleted an attribute from this device, ok, but again, I don't > > understand how this is considered a "fix" other than perhaps the old > > attribute does not relate to this device? > As per USB PD specification: > 28th bit of the fixed supply "sink" PDO represents higher capability (whether sink device needs > more than vSafe5V (eg:12 V) for full functionality). > 28th bit of the fixed supply "source" PDO represents usb_suspend_supported attribute. > Before this patch, 28th bit of sink PDO was wrongly representing usb_suspend_supported > attribute. We had to add the new attribute to correctly represent the 28th bit of sink PDO. > Does it make sense to add fixes tag now if I add these additional details in commit message? > Or do you still prefer not to add fixes tag for this patch? > > Thanks, > Saranya > > > > > And if so, then make that a single patch, with a Fixes: tag, and we > > can > > properly backport that one, and then have a second patch that adds > > the > > new attribute. > > > > Again, adding a new attribute is a "new feature" not a fix, right? This is true. Saranya, please split the patch in two like Greg pointed out. thanks, -- heikki
