On Thu, Feb 09, 2023 at 09:43:59AM +0000, Daniel Scally wrote: > Fix a -Wunused-but-set-variable warning in gadget_string_s_store() A side comment below. ... > if (len > USB_MAX_STRING_LEN) > return -EINVAL; > > - ret = strscpy(string->string, page, size); > - return len; > + return strscpy(string->string, page, size); Do you need above check with strscpy()? You may supply the maximum length and negative error code from the strscpy() will indicate the cut. -- With Best Regards, Andy Shevchenko
