On Wed, Feb 08, 2023 at 10:34:18AM -0600, jassisinghbrar@xxxxxxxxx wrote:
> From: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
>
> The mutex 'spi_bus_mutex' should be used, instead of the spin-lock,
> while changing the state of the kernel-thread.
You forgot to say why this is the case.
> Also changing the
> usb-gadget state need not be protected by a spin-lock.
Why not? Why isn't this a separate change?
> This should fix the Smatch static checker warning
> warn: sleeping in atomic context
>
> Fixes: 48ba02b2e2b1 ("usb: gadget: add udc driver for max3420")
> Signed-off-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
> ---
> drivers/usb/gadget/udc/max3420_udc.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
You forgot a "Reported-by:" line, right?
And odd indentation in your changelog text.
thanks,
greg k-h
