Re: [PATCH] usb: dwc3: Clear DWC3_EVENT_PENDING when count is 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi Thinh,


regarding your suggestion, assume it is not PCIe type,  still have one question,


-       if (evt->flags & DWC3_EVENT_PENDING)
+       if (evt->flags & DWC3_EVENT_PENDING) {
+               if (!evt->count) {
+                       u32 reg = dwc3_readl(dwc->regs, DWC3_GEVNTSIZ(0));
+
+                       if (!(reg & DWC3_GEVNTSIZ_INTMASK))
+                               evt->flags &= ~DWC3_EVENT_PENDING;

do we need to return IRQ_WAKE_THREAD  ?

+               }
                return IRQ_HANDLED;

as here return IRQ HANDLED, how can we make sure a new IRQ will be handled after previous IRQ thread clean PENDING flag ?

+       }


also for non-PCIe controller, consider IRQ mask register working correctly,

consider a case IRQ happen before IRQ thread exit,  here just return IRQ_HANDLED.

once IRQ thread exit, it will clean PENDING flag, so next IRQ event will run normally.

if 정재훈 saw PENDING flag is not cleared, does it mean IRQ thread have no chance to exit ?



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux