Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-linus] [also build test WARNING on westeri-thunderbolt/next linus/master v6.2-rc6 next-20230130] [cannot apply to usb/usb-testing usb/usb-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Scally/usb-gadget-uvc-Make-bSourceID-read-write/20230130-174215 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus patch link: https://lore.kernel.org/r/20230130093443.25644-7-dan.scally%40ideasonboard.com patch subject: [PATCH v3 06/11] usb: gadget: configfs: Support arbitrary string descriptors config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230130/202301302344.mwzUOCim-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/452304e81fac1427f314a4b0beef8561ef4ebf17 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Daniel-Scally/usb-gadget-uvc-Make-bSourceID-read-write/20230130-174215 git checkout 452304e81fac1427f314a4b0beef8561ef4ebf17 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/usb/gadget/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/usb/gadget/configfs.c: In function 'gadget_string_s_store': >> drivers/usb/gadget/configfs.c:811:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 811 | int ret; | ^~~ vim +/ret +811 drivers/usb/gadget/configfs.c 805 806 static ssize_t gadget_string_s_store(struct config_item *item, const char *page, 807 size_t len) 808 { 809 struct gadget_string *string = to_gadget_string(item); 810 int size = min(sizeof(string->string), len + 1); > 811 int ret; 812 813 if (len > USB_MAX_STRING_LEN) 814 return -EINVAL; 815 816 ret = strscpy(string->string, page, size); 817 return len; 818 } 819 CONFIGFS_ATTR(gadget_string_, s); 820 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
