devm_platform_get_and_ioremap_resource() never returns NULL pointer, it will return ERR_PTR() when it fails, so replace the check with IS_ERR(). Fixes: baef5330d35b ("usb: fotg210: Acquire memory resource in core") Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx> --- drivers/usb/fotg210/fotg210-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/fotg210/fotg210-core.c b/drivers/usb/fotg210/fotg210-core.c index 202d80adca2c..fad49f523dee 100644 --- a/drivers/usb/fotg210/fotg210-core.c +++ b/drivers/usb/fotg210/fotg210-core.c @@ -136,7 +136,7 @@ static int fotg210_probe(struct platform_device *pdev) fotg->dev = dev; fotg->base = devm_platform_get_and_ioremap_resource(pdev, 0, &fotg->res); - if (!fotg->base) + if (IS_ERR(fotg->base)) return -ENOMEM; fotg->pclk = devm_clk_get_optional_enabled(dev, "PCLK"); -- 2.25.1