Re: [PATCH v2 1/2] usb: typec: altmodes/displayport: Update active state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/20/23 12:58, Prashant Malani wrote:
Update the altmode "active" state when we receive Acks for Enter and
Exit Mode commands. Having the right state is necessary to change Pin
Assignments using the 'pin_assignment" sysfs file.

Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx>
Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

---

Changes since v1:
- Dropped the Fixes and Cc: stable tags; given the discussion in [1]
   I no longer think this constitutes a fix.
- Added Reviewed-by tag from Benson.

[1] https://lore.kernel.org/linux-usb/20230118031514.1278139-1-pmalani@xxxxxxxxxxxx/

  drivers/usb/typec/altmodes/displayport.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
index 06fb4732f8cd..bc1c556944d6 100644
--- a/drivers/usb/typec/altmodes/displayport.c
+++ b/drivers/usb/typec/altmodes/displayport.c
@@ -277,9 +277,11 @@ static int dp_altmode_vdm(struct typec_altmode *alt,
  	case CMDT_RSP_ACK:
  		switch (cmd) {
  		case CMD_ENTER_MODE:
+			typec_altmode_update_active(alt, true);
  			dp->state = DP_STATE_UPDATE;
  			break;
  		case CMD_EXIT_MODE:
+			typec_altmode_update_active(alt, false);
  			dp->data.status = 0;
  			dp->data.conf = 0;
  			break;




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux