Re: [PATCH v2 6/9] dt-bindings: usb: Add binding for Via lab VL817 hub controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/01/2023 05:44, Anand Moon wrote:
> The VIA Lab VL817 is a USB 3.1 Gen 1 hub and USB 2.0 hub
> controller that features 4 downstream ports and 1 otg, with
> an internal 5V regulator and has external reset pin.

Subject: drop second/last, redundant "binding for". The "dt-bindings"
prefix is already stating that these are bindings.

> 
> Add a device tree binding for its USB protocol part.
> The internal LDO is not covered by this and can just be modelled
> as a fixed regulator.
> 
> Add combo of USB 2.0 and USB 3.0 root hub using peer-hub.
> 
> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
> ---
> v2 - fix the compatible string and fix the $id
>    - update the commit message.
>    - update the example for use peer-hub node because it
>      combo of USB 2.0 and USB 3.0 hub.
>    - rename the yaml file from vialab,vl817q7.yaml to vialab,vl817.yaml
>      as q7 suffix is ued for USB 3.1 and q5 suffix is used for USB 2.0.
> ---
>  .../devicetree/bindings/usb/vialab,vl817.yaml | 69 +++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/vialab,vl817.yaml
> 
> diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
> new file mode 100644
> index 000000000000..5f9771e22058
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/vialab,vl817.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Via labs VL817 USB 3.1 hub controller
> +
> +maintainers:
> +  - Anand Moon <linux.amoon@xxxxxxxxx>
> +
> +allOf:
> +  - $ref: usb-device.yaml#
> +
> +properties:
> +  compatible:
> +    items:

Drop items

> +      - enum:
> +          - usb2109,2817
> +          - usb2109,817
> +
> +  reg: true
> +
> +  reset-gpios:
> +    description: GPIO controlling the RESET# pin.

maxItems

> +
> +  vdd-supply:
> +    description:
> +      phandle to the regulator that provides power to the hub.
> +
> +  peer-hub:
> +    $ref: '/schemas/types.yaml#/definitions/phandle'

Drop quotes

> +    description:
> +      phandle to the peer hub on the controller.
> +
> +required:
> +  - peer-hub
> +  - compatible
> +  - reg

Keep same order as in properties: part.

> +

Best regards,
Krzysztof




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux