On Sun, Jan 15, 2023 at 06:07:27PM -0800, Duke Xin(辛安文) wrote: > The EM05CN (SG) modem has 2 USB configurations that are configurable via the AT > command AT+QCFG="usbnet",[ 0 | 2 ] which make the modem enumerate with > the following interfaces, respectively: > > "MBIM" : AT + MBIM + DIAG + NMEA + MODEM > "RMNET" : AT + DIAG + NMEA + Modem + QMI > > The detailed description of the USB configuration for each mode as follows: > Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@xxxxxxx> > --- Thanks for the update. Patch itself looks good, but you forgot to include a short changelog here below the --- line. I've applied both v3 patches now so no need to send a v4 for this, but please try to remember this for your future contributions. Johan