Hi Johan Thanks for your review comments. On Wed, 28 Dec 2022 at 16:32, Johan Hovold <johan@xxxxxxxxxx> wrote: > > On Wed, Dec 28, 2022 at 10:03:17AM +0000, Anand Moon wrote: > > The VIA Lab VL817-Q7 is a USB 3.1 Gen 1 4-Port hub controller that > > features 4 downstream ports, an internal 5V regulator and has > > external reset pin. > > > > Add a device tree binding for its USB protocol part. > > The internal LDO is not covered by this and can just be modelled > > as a fixed regulator. > > > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > > --- > > .../bindings/usb/vialab,vl817q7.yaml | 47 +++++++++++++++++++ > > 1 file changed, 47 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/vialab,vl817q7.yaml > > > > diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817q7.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817q7.yaml > > new file mode 100644 > > index 000000000000..4ae995160fd5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/vialab,vl817q7.yaml > > @@ -0,0 +1,47 @@ > > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Via labs VL817Q7 USB 3.1 hub controller > > + > > +maintainers: > > + - Anand Moon <linux.amoon@xxxxxxxxx> > > + > > +allOf: > > + - $ref: usb-device.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - vialab,usb2109 > > This isn't a valid compatible string for USB devices (should be > "usb<vid>,<pid>"). > > Same for the other binding. > ok, I will change this in the next version. > Also the bindings should go before the driver changes in the series. > > Johan Thanks -Anand
