Re: [PATCH v4 3/5] usb: gadget: udc: add Renesas RZ/N1 USBF controller support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hervé,

On Tue, Dec 13, 2022 at 2:33 PM Herve Codina <herve.codina@xxxxxxxxxxx> wrote:
> Add support for the Renesas USBF controller.
> This controller is an USB2.0 UDC controller available in the
> Renesas r9a06g032 SoC (RZ/N1 family).
>
> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>

Thanks for your patch!

> --- /dev/null
> +++ b/drivers/usb/gadget/udc/renesas_usbf.c

> +#ifdef DEBUG
> +#define TRACE(_fmt, ...) trace_printk("%s: " _fmt, __func__, ##__VA_ARGS__)
> +#define USBF_TRACE_EP_MASK 0x0ffff /* All the 16 endpoints */
> +#define TRACEEP(_ep, _fmt, ...)                                             \
> +       do {                                                                \
> +               if ((1 << (_ep)->id) & USBF_TRACE_EP_MASK)                  \
> +                       trace_printk("%s: " _fmt, __func__, ##__VA_ARGS__); \
> +       } while (0)
> +#else
> +#define TRACE(_fmt, ...) do { } while (0)
> +#define TRACEEP(_ep, _fmt, ...) do { } while (0)

Please use "no_printk(fmt, ##__VA_ARGS__)" instead of dummy loops,
to avoid bad callers going unnoticed if DEBUG is not defined.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux