On Tue, Dec 20, 2022 at 12:46 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, Dec 19, 2022 at 02:46:10PM -0600, Allen Webb wrote: > > A one character difference in the name supplied to MODULE_DEVICE_TABLE > > breaks a future patch set, so fix the typo. > > > > Cc: stable@xxxxxxxxxxxxxxx > > Fixes: f70ed3b5dc8b ("mailbox: rockchip: Add Rockchip mailbox driver") > > How has this been an issue since the 4.6 kernel and no one has noticed > it? Can this code not be built as a module? If not, then please > explain this. As mentioned in a different sub-thread this cannot be built as a module so I updated the commit message to: imx: Fix typo A one character difference in the name supplied to MODULE_DEVICE_TABLE breaks compilation for SOC_IMX8M after built-in modules can generate match-id based module aliases, so fix the typo. This was not caught earlier because SOC_IMX8M can not be built as a module and MODULE_DEVICE_TABLE is a no-op for built-in modules. Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl") Reported-by: kernel test robot <lkp@xxxxxxxxx> Signed-off-by: Allen Webb <allenwebb@xxxxxxxxxx> > > thanks, > > greg k-h