Re: [PATCH 0/5] usb: uvc: improve header files and function use

Dan Scally <dan.scally@xxxxxxxxxxxxxxxx> · Wed, 14 Dec 2022 10:57:47 +0000

Hi Michael

On 12/12/2022 19:47, Michael Grzeschik wrote:
This series is improving the use of the uvc_format_desc
in v4l2-uvc.h and also reuses the declarative strings from
v4l_fill_fmtdesc.

Michael Grzeschik (5):
   usb: uvc: move media/v4l2-uvc.h to usb/uvc.h
   usb: uvc: move uvc_fmts and uvc_format_by_guid to own compile unit
   usb: uvc: make uvc_format_desc table const
   media: v4l2: move v4l_fill_fmtdesc to common v4l2_fill_fmtdesc
     function
   usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name

For the set:

Reviewed-by: Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx>

Tested-by: Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx>

  drivers/media/common/Kconfig                  |   3 +
  drivers/media/common/Makefile                 |   1 +
  drivers/media/common/uvc.c                    | 177 ++++++++++++
  drivers/media/usb/uvc/Kconfig                 |   1 +
  drivers/media/usb/uvc/uvc_ctrl.c              |   2 +-
  drivers/media/usb/uvc/uvc_driver.c            |  12 +-
  drivers/media/v4l2-core/v4l2-common.c         | 263 +++++++++++++++++
  drivers/media/v4l2-core/v4l2-ioctl.c          | 264 +-----------------
  drivers/usb/gadget/Kconfig                    |   1 +
  drivers/usb/gadget/function/uvc_v4l2.c        |  16 +-
  include/{media/v4l2-uvc.h => linux/usb/uvc.h} | 206 +-------------
  include/media/v4l2-common.h                   |   2 +
  12 files changed, 466 insertions(+), 482 deletions(-)
  create mode 100644 drivers/media/common/uvc.c
  rename include/{media/v4l2-uvc.h => linux/usb/uvc.h} (59%)