On Sat, Dec 03, 2022 at 03:10:27PM +0800, Yang Yingliang wrote:
> I got the following report while doing fault injection test:
>
> OF: ERROR: memory leak, expected refcount 1 instead of 4,
> of_node_get()/of_node_put() unbalanced - destroy cset entry:
> attach overlay node /i2c/tcpc@60/connector
>
> If wusb3801_hw_init() fails, fwnode_handle_put() needs be called to
> avoid refcount leak.
>
> Fixes: d016cbe4d7ac ("usb: typec: Support the WUSB3801 port controller")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/wusb3801.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/wusb3801.c b/drivers/usb/typec/wusb3801.c
> index 3cc7a15ecbd3..a43a18d4b02e 100644
> --- a/drivers/usb/typec/wusb3801.c
> +++ b/drivers/usb/typec/wusb3801.c
> @@ -364,7 +364,7 @@ static int wusb3801_probe(struct i2c_client *client)
> /* Initialize the hardware with the devicetree settings. */
> ret = wusb3801_hw_init(wusb3801);
> if (ret)
> - return ret;
> + goto err_put_connector;
>
> wusb3801->cap.revision = USB_TYPEC_REV_1_2;
> wusb3801->cap.accessory[0] = TYPEC_ACCESSORY_AUDIO;
> --
> 2.25.1
--
heikki
