Re: [PATCH] usb: gadget: uvc: Rename bmInterfaceFlags -> bmInterlaceFlags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg

On 05/12/2022 15:01, Greg KH wrote:
On Mon, Dec 05, 2022 at 02:58:07PM +0000, Daniel Scally wrote:
In the specification documents for the Uncompressed and MJPEG USB
Video Payloads, the field name is bmInterlaceFlags - it has been
misnamed within the kernel.

Although renaming the field does break the kernel's interface to
userspace it should be low-risk in this instance. The field is read
only and hardcoded to 0, so there was never any value in anyone
reading it. A search of our uvc-gadget application and all the major
forks that I could find for it did not reveal any users either.
Note, if this does break someone, we will have to rename it back, ok?

Sounds reasonable to me. The patch Fixes: cdda479f15cd ("USB gadget: video class function driver")



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux