Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Badhri Jagan Sridharan <badhri@xxxxxxxxxx>
Subject: Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 4 Dec 2022 10:43:02 +0100
Cc: Guenter Roeck <linux@xxxxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Kyle Tso <kyletso@xxxxxxxxxx>
In-reply-to: <20221204084844.3573800-3-badhri@google.com>
References: <20221204084844.3573800-1-badhri@google.com> <20221204084844.3573800-3-badhri@google.com>

On Sun, Dec 04, 2022 at 12:48:44AM -0800, Badhri Jagan Sridharan wrote:
> +EXPORT_SYMBOL_GPL(is_contaminant);

Sorry, but this is a horrible name for the kernel global namespace.
Please properly prefix it to show exactly what subsystem this is from.

thanks,

greg k-h

Follow-Ups:
- Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback
  - From: Guenter Roeck

References:
- [PATCH v3 1/3] usb: typec: tcpm: Add callbacks to mitigate wakeups due to contaminant
  - From: Badhri Jagan Sridharan
- [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback
  - From: Badhri Jagan Sridharan

Prev by Date: [PATCH v3 2/3] usb: typec: tcpci: Add callback for evaluating contaminant presence
Next by Date: Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback
Previous by thread: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback
Next by thread: Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback
Index(es):
- Date
- Thread

[Index of Archives] [Linux Media] [Linux Input] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Old Linux USB Devel Archive]

Powered by Linux