Hi Laurent, On Sat, Dec 03, 2022 at 11:26:14PM +0200, Laurent Pinchart wrote:
On Sat, Sep 10, 2022 at 12:13:31AM +0200, Michael Grzeschik wrote:This series improves the uvc video gadget by parsing the configfs entries. With the configfs data, the userspace now is able to use simple v4l2 api calls like enum and try_format to check for valid configurations initially set by configfs.I've realized that this whole series got merged, despite my multiple attempts to explain why I think it's not a good idea. The UVC gadget requires userspace support, and there's no point in trying to move all these things to the kernel side. It only bloats the kernel, makes the code more complex, more difficult to maintain, and will make UVC 1.5 support more difficult.
Those patches that got merged are already a compromise. And I think a better one. Since the last rounds I realized that many steps that I thought would be needed in the kernel, can indeed be made in userspace. So beside thise code that only adds the typical vidioc functions to parse what is configured in configfs. There is nothing that changed the working function of the gadget. That said, it is up to you to use the vidiocs or your application sticks with own parsing of the configfs. So, with that said, I am unsure what you are exactly unhappy about. Beside the points you mentioned in the previous mail.
I'm fairly unhappy with this, it will lower my trust towards your patches.
If you don't trust my patches, than review them or at least nack them with a comment so we have an object of disscussion.
Michael Grzeschik (4): media: v4l: move helper functions for fractions from uvc to v4l2-common media: uvcvideo: move uvc_format_desc to common header usb: gadget: uvc: add v4l2 enumeration api calls usb: gadget: uvc: add v4l2 try_format api call drivers/media/usb/uvc/uvc_ctrl.c | 1 + drivers/media/usb/uvc/uvc_driver.c | 290 +------------------- drivers/media/usb/uvc/uvc_v4l2.c | 14 +- drivers/media/usb/uvc/uvcvideo.h | 147 ---------- drivers/media/v4l2-core/v4l2-common.c | 86 ++++++ drivers/usb/gadget/function/f_uvc.c | 30 +++ drivers/usb/gadget/function/uvc.h | 2 + drivers/usb/gadget/function/uvc_v4l2.c | 286 ++++++++++++++++++++ include/media/v4l2-common.h | 4 + include/media/v4l2-uvc.h | 359 +++++++++++++++++++++++++ 10 files changed, 776 insertions(+), 443 deletions(-) create mode 100644 include/media/v4l2-uvc.h-- Regards, Laurent Pinchart
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
