On Fri, Dec 2, 2022 at 2:25 AM Yi Yang <yiyang13@xxxxxxxxxx> wrote:
> In fotg210_udc_probe(), if devm_clk_get() or clk_prepare_enable()
> fails, 'fotg210' will not be freed, which will lead to a memory leak.
> Fix it by moving kfree() to a proper location.
>
> In addition，we can use "return -ENOMEM" instead of "goto err"
> to simplify the code.
>
> Fixes: 718a38d092ec ("fotg210-udc: Handle PCLK")
> Signed-off-by: Yi Yang <yiyang13@xxxxxxxxxx>
> Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
I have some cleanup patches switching around to devm* handling
cooking for v6.3, but let's do this for now.
Yours,
Linus Walleij
