在 2022/11/29 12:11, Vincent MAILHOL 写道:
On Tue. 29 nov. 2022 à 12:33, Wang Yufen <wangyufen@xxxxxxxxxx> wrote:
Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
instead of 0.
Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
Signed-off-by: Wang Yufen <wangyufen@xxxxxxxxxx>
---
drivers/usb/host/fhci-hcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
index 95a4446..afef72a 100644
--- a/drivers/usb/host/fhci-hcd.c
+++ b/drivers/usb/host/fhci-hcd.c
@@ -639,6 +639,7 @@ static int of_fhci_probe(struct platform_device *ofdev)
NULL, i, GPIOD_OUT_LOW);
if (IS_ERR(fhci->gpiods[i])) {
+ ret = PTR_ERR(fhci->gpiods[i])
dev_err(dev, "incorrect GPIO%d: %ld\n",
i, PTR_ERR(fhci->gpiods[i]));
Can you add some extra clean-up and reuse ret in the dev_err()?
dev_err(dev, "incorrect GPIO%d: %ld\n", i, ret);
I prefer to reuse ret, just like other fhci->*** checks. This also keeps
the code style consistent with the context. Will change in v2.
Thanks.
Alternatively you can also consider %pe to print the mnemotechnic
instead of the value:
dev_err(dev, "incorrect GPIO%d: %pe\n",
i, fhci->gpiods[i]);
Yours sincerely,
Vincent Mailhol
