On Mon. 28 Nov. 2022 at 22:47, Andrew Lunn <andrew@xxxxxxx> wrote: > On Sun, Nov 27, 2022 at 01:22:09AM +0900, Vincent Mailhol wrote: > > Now that the product information is available under devlink, no more > > need to print them in the kernel log. Remove es58x_get_product_info(). > > > > Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > > There is a slim chance this will break something paring the kernel > log, but you are not really supposed to do that. Greg made it clear that this should disappear: https://lore.kernel.org/linux-can/Y2YdH4dd8u%2FeUEXg@xxxxxxxxx/ and I agree. I do not recognize the kernel log as being a stable interface to the userland that we should not break. > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Thank you!
