Re: Convert remaining HCDs to uses_new_polling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 16, 2009 at 04:11:48PM -0400, Alan Stern wrote:
> We have had the hcd->uses_new_polling flag for many years now, so by 
> this time all the HCDs should be setting it.  But a few laggards 
> aren't.  Accordingly, this patch adds the flag to the drivers that 
> don't already set it.
> 
> I doubt this will make any difference in the drivers' behavior, but 
> it would be good to test the patch just in case.  Please let me know if 
> it causes any problems.

Unfortunately, the new polling doesn't work with FHCI driver, it
is unable to detect any devices (full or low speed doesn't matter).

It's most probably related to a root hub handling, in FHCI there
is no real root hub, i.e. FHCI has one raw port, and the driver
emulating the hub states in software. I'll take a look at that...

> Index: usb-2.6/drivers/usb/host/fhci-hcd.c
> ===================================================================
> --- usb-2.6.orig/drivers/usb/host/fhci-hcd.c
> +++ usb-2.6/drivers/usb/host/fhci-hcd.c
> @@ -345,6 +345,7 @@ static int fhci_start(struct usb_hcd *hc
>  	}
>  
>  	spin_lock_init(&fhci->lock);
> +	hcd->uses_new_polling = 1;
>  
>  	/* connect the virtual root hub */
>  	fhci->vroot_hub->dev_num = 1;	/* this field may be needed to fix */


Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@xxxxxxxxx
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux