Hi Xia, thanks for your patch! On Wed, Nov 23, 2022 at 3:15 AM Xia Fukun <xiafukun@xxxxxxxxxx> wrote: > The combination of CONFIG_USB_FOTG210_UDC=y and > CONFIG_USB_GADGET=m results in the following error: (...) > Make USB_FOTG210_UDC depends on USB_GADGET=y to fix this. > > Fixes: 1dd33a9f1b95 ("usb: fotg210: Collect pieces of dual mode controller") > Signed-off-by: Xia Fukun <xiafukun@xxxxxxxxxx> Isn't this patch that Greg already merged fixing this issue more thoroughly? https://lore.kernel.org/linux-usb/20221111144821.113665-1-linus.walleij@xxxxxxxxxx/ Please have a look & test! Yours, Linus Walleij