Greg Kroah-Hartman wrote: > The devnode() callback in struct device_type should not be modifying the > device that is passed into it, so mark it as a const * and propagate the > function signature changes out into all relevant subsystems that use > this callback. > > Cc: Jens Axboe <axboe@xxxxxxxxx> > Cc: Alison Schofield <alison.schofield@xxxxxxxxx> > Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx> > Cc: Ira Weiny <ira.weiny@xxxxxxxxx> > Cc: Ben Widawsky <bwidawsk@xxxxxxxxxx> > Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > Cc: Jeremy Kerr <jk@xxxxxxxxxx> > Cc: Joel Stanley <joel@xxxxxxxxx> > Cc: Alistar Popple <alistair@xxxxxxxxxxxx> > Cc: Eddie James <eajames@xxxxxxxxxxxxx> > Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> > Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Cc: Jilin Yuan <yuanjilin@xxxxxxxxxx> > Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Jason Gunthorpe <jgg@xxxxxxxx> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx> > Cc: Won Chung <wonchung@xxxxxxxxxx> > Cc: linux-block@xxxxxxxxxxxxxxx > Cc: linux-cxl@xxxxxxxxxxxxxxx > Cc: linux-fsi@xxxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: linux-usb@xxxxxxxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> [..] > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index 20ce488a7754..6ae8d0bdc61b 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -27,7 +27,7 @@ static void cxl_memdev_release(struct device *dev) > kfree(cxlmd); > } > > -static char *cxl_memdev_devnode(struct device *dev, umode_t *mode, kuid_t *uid, > +static char *cxl_memdev_devnode(const struct device *dev, umode_t *mode, kuid_t *uid, > kgid_t *gid) > { > return kasprintf(GFP_KERNEL, "cxl/%s", dev_name(dev)); For the CXL bit: Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>