On Thu, Nov 17, 2022 at 01:26:21PM +0000, Lee Jones wrote: > On Thu, 17 Nov 2022, Greg KH wrote: > > > On Thu, Nov 17, 2022 at 12:08:13PM +0000, Lee Jones wrote: > > > A reference to struct f_hidg is shared with this driver's associated > > > character device handling component without provision for life-time > > > handling. In some circumstances, this can lead to unwanted > > > behaviour depending on the order in which things are torn down. > > > > > > Utilise, the reference counting functionality already provided by the > > > implanted character device structure to ensure the struct f_hidg's > > > memory is only freed once the character device handling has finished > > > with it. > > > > > > Signed-off-by: Lee Jones <lee@xxxxxxxxxx> > > > --- > > > drivers/usb/gadget/function/f_hid.c | 47 +++++++++++++++++++++++------ > > > 1 file changed, 37 insertions(+), 10 deletions(-) > > > > Hi, > > > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > > a patch that has triggered this response. He used to manually respond > > to these common problems, but in order to save his sanity (he kept > > writing the same thing over and over, yet to different people), I was > > created. Hopefully you will not take offence and will fix the problem > > in your patch and resubmit it so that it can be accepted into the Linux > > kernel tree. > > > > You are receiving this message because of the following common error(s) > > as indicated below: > > > > - This looks like a new version of a previously submitted patch, but you > > did not list below the --- line any changes from the previous version. > > Please read the section entitled "The canonical patch format" in the > > kernel file, Documentation/SubmittingPatches for what needs to be done > > here to properly describe this. > > > > If you wish to discuss this problem further, or you have questions about > > how to resolve this issue, please feel free to respond to this email and > > Greg will reply once he has dug out from the pending patches received > > from other developers. > > > > thanks, > > > > greg k-h's patch email bot > > This is a completely new solution to the same problem. > > I'm treating this as a brand new submission. With the identical subject line, which plays havoc with tools :( This is a v2, next should be v3 please. thanks, greg k-h
