On 10/11/22 05:40, Jakub Kicinski wrote:
On Wed, 9 Nov 2022 15:43:21 +1100 Albert Zhou wrote:The version-one r8152 module, for some reason, cannot maintain high data-transfer speeds. I personally experienced this problem myself, when I bought a new USB-C to ethernet adapter. The version-two module fixes this issue.I see, perhaps it'd be possible to zero in on how the datapath of the driver is implemented?
Hi all, After a lot of testing, I have come to the conclusion that the reason for the speed difference between the v1 and v2 driver is actually the firmware. The v2 driver doesn't even #include <linux/firmware.h>; so it doesn't load the standard firmware in /lib/firmware/rtl_nic. It seems the firmware is actually written in the source and loaded directly. Since firmware is not even part of the kernel, it's probably inappropriate to submit a patch that modifies the firmware of a device, would that be correct? If that's the case, it's probably best if Realtek can update the firmware on the linux firmware git. Not sure otherwise how to proceed. Any suggestions? Best, Albert
Attachment:
OpenPGP_0x218FE344C5A6867D.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
