Hello!
On 11/14/22 2:52 PM, Linus Walleij wrote:
> The platform_get_irq() is necessary to use to get dynamic
> IRQ resolution when instantiating the device from the
> device tree. IRQs are not passed as resources in that
> case.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
[...]
> diff --git a/drivers/usb/fotg210/fotg210-udc.c b/drivers/usb/fotg210/fotg210-udc.c
> index de0f72ca103c..44dfe66e189c 100644
> --- a/drivers/usb/fotg210/fotg210-udc.c
> +++ b/drivers/usb/fotg210/fotg210-udc.c
[...]
> @@ -1157,9 +1158,9 @@ int fotg210_udc_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - ires = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - if (!ires) {
> - pr_err("platform_get_resource IORESOURCE_IRQ error.\n");
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0) {
> + pr_err("could not get irq\n");
platform_get_irq() already curses on irq < 0...
[...]
MBR, Sergey
